Skip to content

Add dataCast1 definition for HashMap #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2021
Merged

Add dataCast1 definition for HashMap #345

merged 1 commit into from
Dec 22, 2021

Conversation

treeowl
Copy link
Collaborator

@treeowl treeowl commented Dec 22, 2021

This was supposed to be in #344, but I messed up.

@treeowl treeowl merged commit bd165b0 into haskell-unordered-containers:master Dec 22, 2021
@sjakobi
Copy link
Member

sjakobi commented Dec 23, 2021

What's the motivation for this change?

@treeowl
Copy link
Collaborator Author

treeowl commented Dec 23, 2021

It's what's expected for Data instances. If you can define dataCast1 f = gcast1 f, then you should. Previously we had a weird sort of situation where dataCast1 would say "no you can't" about the same operation.

@sjakobi sjakobi mentioned this pull request Dec 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treeowl @sjakobi