add mapKeys #308
Merged
add mapKeys #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
reviewed
Mar 26, 2021
sjakobi
reviewed
Mar 26, 2021
|
@sjakobi I addressed your recommendations. Should be ready now |
sjakobi
reviewed
Mar 29, 2021
Co-authored-by: Simon Jakobi <[email protected]>
sjakobi
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds
mapKeysto the API, following the implementation provided bycontainers.I'm not an expert in performances and on the internals of
unordered-containers, so feel free to refuse this if it is not up to the standards of the library