Custom errors for HasClient, HasServer #1486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the approach from #1289 to
HasServer
andHasClient
.The
context
parameter is missing from the missing instance message in one case, but I am not sure it is a big enough problem to warrant making the code more complex.In the process, I realized there was already a similar mechanism in place to detect usage errors for
HasServer
. The mechanism #1289 supersedes it, as it produces more informative messages, displays the number of missing parameters, etc.