Skip to content

servant-client-core: Redact Authorization header #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2019
Merged

servant-client-core: Redact Authorization header #1238

merged 2 commits into from
Dec 14, 2019

Conversation

roberth
Copy link
Contributor

@roberth roberth commented Nov 5, 2019

Prevent credentials leaking in exception messages.

@domenkozar domenkozar requested a review from phadej November 5, 2019 15:56
phadej
phadej reviewed Nov 5, 2019
View reviewed changes
servant-client-core/src/Servant/Client/Core/Request.hs
showsPrec p req
= showParen
(p >= 11)
( showString "Request {requestPath = "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$

phadej
phadej suggested changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@phadej phadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/haskell-servant/servant/blob/master/CONTRIBUTING.md#changelog-entries

@roberth roberth requested a review from phadej November 12, 2019 14:02
@roberth
Copy link
Contributor Author

roberth commented Nov 12, 2019

I completely missed the final comment on the review.

@domenkozar
Copy link
Contributor

We published the advisory for cachix: GHSA-5v3x-gf4h-9qrh

@nh2
Copy link

nh2 commented Nov 22, 2019

For my record, these are the relevant nixpkgs commits (thanks @domenkozar):

@phadej phadej merged commit e103952 into haskell-servant:master Dec 14, 2019
@phadej phadej mentioned this pull request Dec 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phadej phadej Awaiting requested review from phadej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roberth @domenkozar @nh2 @phadej