WIP: servant-http-streams #1117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpmestan
reviewed
Feb 5, 2019
| input = ["foo", "", "bar"] | ||
| output = ["foo", "bar"] | ||
|
|
||
| {- |
There was a problem hiding this comment.
just temporarily commented out? or is it a way to tag this as something to revisit later?
There was a problem hiding this comment.
that test isn't enabled for servant-client either, I'll delete it from servant-http-streams though. I really don't know how one could test constant memory usage. Maybe something like weigh; dunno.
There was a problem hiding this comment.
OK, then yes I'd suggest to remove this or alternatively explain why it's commented out right at the beginning of the comment, as you prefer. (depends on how likely we are to revisit the constant-memory testing)
- Rename GenResponse to ResponseF (analogous to RequestF) - add NFData Headers - Make Request and Response bodies be SourceIO, i.e. move conversions into specific implementations
0b9a231 to
b44335a
Compare
|
Rewrote history, to make it clearer what happened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.