Add unwatch request #473
Merged
Add unwatch request #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b120986 to
5281a50
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
5281a50 to
7498a53
Compare
|
@414owen : Can this PR be complemented by a test case or a demonstration in |
andreasabel
requested changes
Apr 19, 2022
|
@andreasabel I've added a sample to demonstrate usage of |
andreasabel
requested changes
Apr 20, 2022
samples/Repos/Watching/Unwatch.hs
Outdated
| @@ -0,0 +1,17 @@ | |||
| {-# LANGUAGE OverloadedStrings #-} | |||
|
|
|||
| module Unwatch where | |||
There was a problem hiding this comment.
Could you please add this to the executables in samples/github-samples.cabal so that it gets built by the CI?
(You will likely have to delete the module header or change it to Main to get ghc to build the executable.)
andreasabel
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
As I suspected, a main module can only have name Main (or no name):
Building executable 'github-unwatch-repo' for github-samples-0..
[1 of 1] Compiling Unwatch ( Repos/Watching/Unwatch.hs, /__w/github/github/dist-newstyle/build/x86_64-linux/ghc-8.0.2/github-samples-0/x/github-unwatch-repo/noopt/build/github-unwatch-repo/github-unwatch-repo-tmp/Unwatch.o )
<no location info>: error:
output was redirected with -o, but no output will be generated
because there is no Main module.
andreasabel
requested changes
Apr 28, 2022
4ae5f0a to
c527dbe
Compare
|
Thanks a lot, @414owen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up subscribed to a bunch of repositories, through some automated process.
This helped clear it up.
@phadej