-
Notifications
You must be signed in to change notification settings - Fork 194
Missing parts of the API for repository issues #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- remove unused imports - disable star-is-type warning while we are supporting GHC 7
Add missing methods to set the following fields of 'IssueRepoOptions': - specific milestone - specific assignee - creator - mentioned
Ping @phadej. The workflow needs to be started manually. |
Thanks for the review, @phadej! I updated the PR accordingly. |
@phadej, what's the plan? Can you release this fix? |
@andreasabel do you want to be come the maintainer of (I have been looking for someone to look after this library for quite some time) |
@phadej Yes, I am happy to maintain |
@phadej ping. |
I cannot transfer this repository as andreasabel/github already exists |
Ah, sorry about that. I renamed the fork, hope it works now. |
Looks like that's not enough, it still errors with
|
@phadej: Sorry, I got distracted. I now created a new organization to host this project: https://github.com/haskell-github |
Motivation: see issue #286 and agda/agda#5691
Closes: #286 and #287
Needs: release (e.g. 0.28)
As observed in #286 and #287, the API for listing repository issues, see https://docs.github.com/en/rest/reference/issues#list-repository-issues, is incompletely reflected in
github-0.27
. Esp. the functionality to get just the issues for a particular milestone is not exported.This PR adds the missing parts of the API as new methods to construct
IssueRepoMod
.With the functionality added by this PR, the API is now complete. In particular, I conjecture the following completeness statement:
In contrast, the API of 0.27 is incomplete:
Successful CI run at: https://github.com/andreasabel/github/actions/runs/1556147789