Skip to content

Update EditRepo type #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2019
Merged

Conversation

matsubara0507
Copy link
Contributor

ref: https://developer.github.com/v3/repos/#edit

is_template key is currently available for developer to preview.
So, I didn't added this one.

FYI, Repo and NewRepo have updating (ref: https://developer.github.com/v3/repos/#create).
Should I make this one?

(I updated only EditRepo because I needed only new EditRepo.)

@phadej
Copy link
Contributor

phadej commented Oct 19, 2019

Thanks!

It would be great to update Repo and NewRepo as well, as we on it.

Copy link
Contributor

@phadej phadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update NewRepo and Repo too.

@phadej phadej merged commit fdbe626 into haskell-github:master Oct 22, 2019
@phadej
Copy link
Contributor

phadej commented Oct 22, 2019

Thanks!

@matsubara0507
Copy link
Contributor Author

Updated Repo and NewRepo.

exec by ghci

>> createRepo' auth $ NewRepo "test-github-hs" (Just "test") (Just "https://matsubara0507.github.io") (Just False) (Just True) (Just True) (Just True) (Just False) (Just "Haskell") (Just "MIT") (Just True) (Just True) (Just True)
Right (Repo {repoId = Id 216769026, repoName = N "test-github-hs", repoOwner = SimpleOwner {simpleOwnerId = Id 10684493, simpleOwnerLogin = N "matsubara0507", simpleOwnerUrl = URL "https://api.github.com/users/matsubara0507", simpleOwnerAvatarUrl = URL "https://avatars1.githubusercontent.com/u/10684493?v=4", simpleOwnerType = OwnerUser}, repoPrivate = False, repoHtmlUrl = URL "https://github.com/matsubara0507/test-github-hs", repoDescription = Just "test", repoFork = Just False, repoUrl = URL "https://api.github.com/repos/matsubara0507/test-github-hs", repoGitUrl = Just (URL "git://github.com/matsubara0507/test-github-hs.git"), repoSshUrl = Just (URL "[email protected]:matsubara0507/test-github-hs.git"), repoCloneUrl = Just (URL "https://github.com/matsubara0507/test-github-hs.git"), repoHooksUrl = URL "https://api.github.com/repos/matsubara0507/test-github-hs/hooks", repoSvnUrl = Just (URL "https://github.com/matsubara0507/test-github-hs"), repoHomepage = Just "https://matsubara0507.github.io", repoLanguage = Nothing, repoForksCount = 0, repoStargazersCount = 0, repoWatchersCount = 0, repoSize = Just 0, repoDefaultBranch = Just "master", repoOpenIssuesCount = 0, repoHasIssues = Just True, repoHasProjects = Just True, repoHasWiki = Just True, repoHasPages = Just False, repoHasDownloads = Just True, repoArchived = False, repoDisabled = False, repoPushedAt = Just 2019-10-22 09:01:08 UTC, repoCreatedAt = Just 2019-10-22 09:01:04 UTC, repoUpdatedAt = Just 2019-10-22 09:01:04 UTC})

Repo type different is:

  • add forks_count, watchers_count, open_issues_count
    • these are rename by forks, watchers, open_issues
    • old names is still exists in response (but, not exist in documents).
    • so, no remove old properties
  • add has_projects, has_pages, disabled
  • remove parent, source

and no changes is:

  • no add node_id (because, I'm not sure about this property)
  • no add full_name
  • no add xxx_url properties
    • because, very very many exist
  • no add is_template, template_repository and topics (this is beta feature)
  • no add permissions and license
    • because, need new data structures.
  • no add subscribers_count and network_count (because, I'm not sure about this property)

@matsubara0507
Copy link
Contributor Author

Oh, thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants