Skip to content

Escape URI paths #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2019
Merged

Escape URI paths #404

merged 2 commits into from
Sep 30, 2019

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Sep 29, 2019

Resolves #398

ping @domenkozar, does this works for your use case?

domenkozar
domenkozar reviewed Sep 29, 2019
View reviewed changes
src/GitHub/Request.hs Outdated
import Data.List (find)
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@domenkozar
Copy link
Contributor

I haven't tested it, but I'm using the same function to pass the path, so it should work.

@phadej phadej merged commit 1eb7257 into master Sep 30, 2019
@phadej phadej deleted the escape-paths branch September 30, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar domenkozar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URI escape segments before sending them to github
2 participants
@phadej @domenkozar