Supported DCR tag pages for all #27185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behind a switch to enable turning off
mxdvl
commented
May 28, 2024
| @@ -19,11 +19,11 @@ object TagPagePicker extends GuLogging { | |||
| request.isJson, | |||
| request.forceDCROff, | |||
| request.forceDCR, | |||
| participatingInTest, | |||
| isSwitchedOn, | |||
| dcrCouldRender(checks), | |||
There was a problem hiding this comment.
We need to make sure that this these checks are sufficient – @guardian/dotcom-platform
|
Amazing! 🤩🤩🤩 |
This was referenced May 29, 2024
|
Seen on FRONTS-PROD, ADMIN-PROD (merged by @mxdvl 13 minutes and 7 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
DCR tag pages for all
What does this change?
Turn the experiment into a feature switch.
Screenshots
Checklist