Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set affiliate links live #27168

Merged
merged 8 commits into from
May 21, 2024
Merged

Set affiliate links live #27168

merged 8 commits into from
May 21, 2024

Conversation

emma-imber
Copy link
Contributor

@emma-imber emma-imber commented May 21, 2024

What does this change?

Removes the zero percent test that DCR skimlinks were behind and no longer use contentType, an allowList or a cut-off date to decide skimlinks eligibility.

This means affiliate links will now show for:

  • all galleries with affiliatable links
  • all DCR articles where:
    • there are affiliatable links
    • the first two page elements are paragraphs
    • the second paragraph is longer than 250 characters

Screenshots

Desktop:

Screenshot 2024-05-21 at 15 46 41

Mobile:

Screenshot 2024-05-21 at 15 46 58

Copy link
Contributor

@SiAdcock SiAdcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @emma-imber 💎 💎 💎

@emma-imber emma-imber marked this pull request as ready for review May 21, 2024 15:17
@emma-imber emma-imber requested a review from a team as a code owner May 21, 2024 15:17
@SiAdcock SiAdcock merged commit aeb19f7 into main May 21, 2024
3 checks passed
@SiAdcock SiAdcock deleted the ei/set-affiliate-links-live branch May 21, 2024 15:50
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (created by @emma-imber and merged by @SiAdcock 14 minutes and 19 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (created by @emma-imber and merged by @SiAdcock 14 minutes and 25 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants