Add explicit availability annotations #2234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: gRPC is moving from specifying the platforms in the package manifest to annotating code with availability annotations. Modifications: - Explicitly annotate public API - Add '-require-explicit-availability' to CI - Drop platforms Result: - gRPC can be used by packages which don't specify their platforms in the manifest
gjcairo
reviewed
May 13, 2025
Comment on lines
+53
to
+60
| let nextMinorVersion = 2 | ||
| let availabilitySettings: [SwiftSetting] = (0 ... nextMinorVersion).map { minor in | ||
| let name = "gRPCSwift" | ||
| let version = "2.\(minor)" | ||
| let platforms = "macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0" | ||
| let setting = "AvailabilityMacro=\(name) \(version):\(platforms)" | ||
| return .enableExperimentalFeature(setting) | ||
| } |
There was a problem hiding this comment.
Are we handling each minor separately (instead of just having a gRPCSwift 2 macro) in case we eventually add new APIs that have higher platform requirements?
With this logic, we tie each whole minor to a set of platforms. What if we ever decide to add some new API that requires higher platform requirements, alongside other new API which could keep the previous platform requirements? Would we just bump all of the new APIs to use the new platforms?
gjcairo
approved these changes
May 13, 2025
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
May 17, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `gRPC Swift` to 2.2.1. ### Why are the changes needed? To bring the latest bug fixes. - https://github.com/grpc/grpc-swift/releases/tag/2.2.1 - grpc/grpc-swift#2234 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #161 from dongjoon-hyun/SPARK-52197. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
gRPC is moving from specifying the platforms in the package manifest to annotating code with availability annotations.
Modifications:
Result: