COMPILING.md: update protoc version requirement #7064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
older version can't compile new proto3 field presence changes (#7058) ``` > Task :grpc-compiler:compileJava_pluginExecutableJava_pluginCpp FAILED Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/5.6.2/userguide/command_line_interface.html#sec:command_line_warnings 67 actionable tasks: 21 executed, 46 up-to-date <-------------> 0% WAITING > Resolve files of :grpc-android-interop-testing:debugCompileClasspath > Transf > Transforming artifact annotations.jar (com.google.android:annotations:4.1.1.4 > Resolve files of :grpc-android-interop-testing:debugCompileClasspath > Transf > :grpc-android:verifyReleaseResources /home/jihuncho/git/grpc-java/compiler/src/java_plugin/cpp/java_plugin.cpp:46:12: error: ‘uint64_t JavaGrpcGenerator::GetSupportedFeatures() const’ marked ‘override’, but does not override 46 | uint64_t GetSupportedFeatures() const override { | ^~~~~~~~~~~~~~~~~~~~ /home/jihuncho/git/grpc-java/compiler/src/java_plugin/cpp/java_plugin.cpp: In member function ‘uint64_t JavaGrpcGenerator::GetSupportedFeatures() const’: /home/jihuncho/git/grpc-java/compiler/src/java_plugin/cpp/java_plugin.cpp:47:12: error: ‘FEATURE_PROTO3_OPTIONAL’ was not declared in this scope 47 | return FEATURE_PROTO3_OPTIONAL; | ^~~~~~~~~~~~~~~~~~~~~~~ ```
dapengzhang0
approved these changes
May 27, 2020
possibly yes. I was using |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
older version can't compile new proto3 field presence changes (#7058)