xds: change route data validation logic #7047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidzcy
commented
May 18, 2020
| // For now we consider the whole list invalid if anything invalid for grpc is found. | ||
| // TODO(zdapeng): Fix it if the decision is different from current implementation. | ||
| // TODO(zdapeng): Add test for validation. | ||
| for (EnvoyProtoData.Route route : routes) { |
There was a problem hiding this comment.
Justification: The converted object EnvoyProtoData.Route is guaranteed to have one of cluster or weighted_cluster set. So this logic is redundant here.
| if (!enableExperimentalRouting) { | ||
| EnvoyProtoData.Route defaultRoute = Iterables.getLast(routes); | ||
| if (defaultRoute.getRouteAction().getCluster() == null) { |
There was a problem hiding this comment.
No longer require the default route to have cluster as the cluster_specifier.
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
Changed the logic of parsing Route to skip Routes with action that specifies cluster_header. Eliminate unnecessary validation logic in XdsClientImpl, of which is already covered in converters.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routes with action of specifyingcluster_headershould be skipped.