rls: add bazel build rule #7019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapengzhang0
reviewed
May 7, 2020
| "//stub", | ||
| "@com_google_code_findbugs_jsr305//jar", | ||
| "@com_google_guava_guava//jar", | ||
| "@io_grpc_grpc_proto//:rls_java_proto", |
There was a problem hiding this comment.
If other languages make a breaking change to grpc-proto and grpc-java will fail, we they notice in the first time?
There was a problem hiding this comment.
at least, they will notice when they are trying to import to google3. although there shouldn't be any breaking changes.
dapengzhang0
approved these changes
May 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.