rls: allow test to provide default caching client builder #7014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapengzhang0
reviewed
May 6, 2020
| * Provides {@link CachingRlsLbClient.Builder} with default settings. This is useful for | ||
| * testing. | ||
| */ | ||
| interface CachingRlsLbClientBuilderProvider { |
There was a problem hiding this comment.
Seems all you want is to inject throttle, ]why not just ThrottlerProvider?
There was a problem hiding this comment.
yeah that was my initial thought. Sooner than later we may need more and more of those Providers. Providing default builder is more flexible without adding test specific codes/classes. e.g. I am thinking we may need to add timeProvider and evictionListener in near future.
dapengzhang0
approved these changes
May 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.