Skip to content

context: Cleanup ContextTest, use final, remove throws, use assertNull #6941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

context: Cleanup ContextTest, use final, remove throws, use assertNull #6941

merged 1 commit into from
Apr 17, 2020

Conversation

bogdandrutu
Copy link
Contributor

No description provided.

@creamsoup creamsoup added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 17, 2020
creamsoup
creamsoup approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @voidzcy can you take a look?

@voidzcy voidzcy changed the title Cleanup ContextTest, use final, remove throws, use assertNull context: Cleanup ContextTest, use final, remove throws, use assertNull Apr 17, 2020
@voidzcy voidzcy merged commit 52a72e2 into grpc:master Apr 17, 2020
@bogdandrutu bogdandrutu deleted the cleanupctxtest branch April 17, 2020 17:38
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@dfawley
context: Cleanup ContextTest, use final, remove throws, use assertNull (
b0f678b 
grpc#6941)

Signed-off-by: Bogdan Drutu <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@voidzcy voidzcy voidzcy approved these changes

@creamsoup creamsoup creamsoup approved these changes

Assignees
No one assigned
Labels
kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdandrutu @voidzcy @creamsoup