xds: eliminate special code path for EDS-only workflow #6931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
683c04f to
56f7121
Compare
ef242e7 to
0afa188
Compare
… allow this for EDS only workflow.
dapengzhang0
approved these changes
Apr 16, 2020
| assertThat(config.endpointPickingPolicy.getProvider().getPolicyName()) | ||
| .isEqualTo("round_robin"); | ||
| } | ||
| } |
…inate_eds_only_work_flow
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
Delete special logics (e.g., fallback) for EDS-only workflow and use the same format of lb config for running EDS-only workflow as running the full CDS-EDS workflow.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding change in C-core: grpc/grpc#22648
Eliminated the adapter class (i.e.,
XdsLoadBalancer) for running standalone EDS lb policy, in which name resolver receives a service config the specifies "xds_experimental" as the load balancing policy and the load balancing config is parsed toXdsConfig.Still preserve the capability of running EDS lb policy alone without fallback. Running EDS only requires the same format of EDS lb config for running it with full CDS-EDS flow.