benchmark: Specify passthrough resolver to avoid resolution failures #8231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8231 +/- ##
==========================================
+ Coverage 81.99% 82.18% +0.18%
==========================================
Files 410 410
Lines 40389 40389
==========================================
+ Hits 33116 33192 +76
+ Misses 5893 5839 -54
+ Partials 1380 1358 -22 🚀 New features to boost your workflow:
|
easwars
approved these changes
Apr 7, 2025
purnesh42H
pushed a commit
to purnesh42H/grpc-go
that referenced
this pull request
Apr 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7970, the benchmarking code was changed to use
NewClientinstead ofDialto create channels. This changed the default resolver frompassthroughtodns. The usage fixed in this PR depended on the custom dialer dialing a fixed address irrespective of the resolver. Since the target was empty, the DNS resolver produces an error and causing RPCs to fail.RELEASE NOTES: N/A