Skip to content

bug: native-maven-plugin doesn't work if defined in parent pom #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dzou opened this issue Oct 20, 2021 · 0 comments · Fixed by #146
Closed

bug: native-maven-plugin doesn't work if defined in parent pom #144

dzou opened this issue Oct 20, 2021 · 0 comments · Fixed by #146
Labels
bug Something isn't working maven-plugin Related to Maven plugin

Comments

@dzou
Copy link

dzou commented Oct 20, 2021 •
edited
Loading

It seems like in version 0.9.6, if the native-maven-plugin is defined in the parent pom and tests are run from the root directory, the test-ids file does not get generated correctly for the child modules and it will enter test-discovery mode which will fail.

Here is a reproducer: https://github.com/dzou/native-maven-plugin-repro-multi-module
@melix melix added bug Something isn't working maven-plugin Related to Maven plugin labels Oct 22, 2021
melix added a commit that referenced this issue Oct 22, 2021
@melix
Fix Native configuration not applied on modules
5d8f55c 
This commit fixes a bug in the Maven plugin, when the extension is
declared in a parent POM: the configuration wouldn't be applied to
subprojects which use the plugin.

Fixes #144
@melix melix mentioned this issue Oct 22, 2021
Merged
melix added a commit that referenced this issue Oct 22, 2021
@melix
Fix Native configuration not applied on modules
7255861 
This commit fixes a bug in the Maven plugin, when the extension is
declared in a parent POM: the configuration wouldn't be applied to
subprojects which use the plugin.

Fixes #144
@dzou dzou mentioned this issue Nov 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working maven-plugin Related to Maven plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Native configuration not applied on modules graalvm/native-build-tools
2 participants
@melix @dzou