chore: Update publish_javadoc.sh #864
Conversation
* add `export` to the envVar's to make sure maven knows about them. * report the Java version
| @@ -59,6 +59,9 @@ python3 -m docuploader upload . \ | |||
|
|
|||
| popd | |||
|
|
|||
| # V2 currently requires Java 8 ONLY. | |||
There was a problem hiding this comment.
Could you check for Java 8 instead of printing the version?
There was a problem hiding this comment.
Why? It's just there to remind someone when they run across a problem.
* remove `java -version`
| @@ -59,7 +59,8 @@ python3 -m docuploader upload . \ | |||
|
|
|||
| popd | |||
|
|
|||
| # V2 | |||
| # V2 due to problems w/ the released javadoc plugin doclava, Java 8 is required. Beware of accidental updates. | |||
There was a problem hiding this comment.
should we be locking the version of the plugin in the pom.xml then?
Is "doclava" correct?
There was a problem hiding this comment.
It's done. DocLava hasn't been published (by us) in 6 years. I'm trying to get this released so we can the CloudRAD done. We are also working on a replacement.
There was a problem hiding this comment.
OK. I just never encountered that before. I'm still having trouble parsing this comment. It might be worth rewriting.
| @@ -59,7 +59,8 @@ python3 -m docuploader upload . \ | |||
|
|
|||
| popd | |||
|
|
|||
| # V2 | |||
| # V2 due to problems w/ the released javadoc plugin doclava, Java 8 is required. Beware of accidental updates. | |||
There was a problem hiding this comment.
OK. I just never encountered that before. I'm still having trouble parsing this comment. It might be worth rewriting.
exportto the envVar's to make sure maven knows about them.@tbpg FYI