Skip to content

test: fix HttpRpcContextTest to not attempt environment credentials resolution #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

BenWhitehead
Copy link
Collaborator

No description provided.

@BenWhitehead BenWhitehead requested a review from a team as a code owner January 10, 2025 21:31
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Jan 10, 2025
Copy link
Contributor

@danielduhh danielduhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the backstory?

@BenWhitehead
Copy link
Collaborator Author

Someone on another team was attempting to run our unit tests, and run into failures due to the lack of credentials present in their environment but with access to the metadata service.

This test should be a unit test, but slipped through our detection so far because we haven't run our unit tests in that type of configuration.

@BenWhitehead BenWhitehead merged commit ce00122 into main Jan 22, 2025
20 of 21 checks passed
@BenWhitehead BenWhitehead deleted the test-creds-fix branch January 22, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants