Skip to content

test(retry): fix objects.compose tests #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

test(retry): fix objects.compose tests #1062

merged 1 commit into from
Oct 4, 2021

Conversation

BenWhitehead
Copy link
Collaborator

  • fix incorrect evaluation of idempotency for objects.compose (now generation, previously metageneration)
  • add mapping for non-idempotent objects.compose invocation
  • add CtxFunction to construct a ComposeRequest relative to the state
  • add ComposeRequest handling to state

@BenWhitehead BenWhitehead requested a review from frankyn October 1, 2021 20:20
@BenWhitehead BenWhitehead requested review from a team as code owners October 1, 2021 20:20
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Oct 1, 2021
@BenWhitehead
test(retry): fix objects.compose tests
b4e663a 
* fix incorrect evaluation of idempotency for objects.compose (now generation, previously metageneration)
* add mapping for non-idempotent objects.compose invocation
* add CtxFunction to construct a ComposeRequest relative to the state
* add ComposeRequest handling to state
@BenWhitehead BenWhitehead merged commit 4478b9d into googleapis:main Oct 4, 2021
@BenWhitehead BenWhitehead deleted the retry-confirmance-trests/fixes-4 branch October 4, 2021 16:16
@BenWhitehead BenWhitehead added this to the Retry Conformance Project milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
Retry Conformance Project
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWhitehead @frankyn