Skip to content

Commit ba5c11a

Browse files
deps: update gcr.io/cloud-devrel-public-resources/storage-testbench docker tag to v0.36.0 (#2080)
* chore: update HttpStorageRpc to avoid content-encoding: gzip on an empty request body Co-authored-by: BenWhitehead <[email protected]>
1 parent 5f916fb commit ba5c11a

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/HttpStorageRpc.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -1103,6 +1103,7 @@ private RewriteResponse rewrite(RewriteRequest req, String token) {
11031103

11041104
Long maxBytesRewrittenPerCall =
11051105
req.megabytesRewrittenPerCall != null ? req.megabytesRewrittenPerCall * MEGABYTE : null;
1106+
StorageObject content = req.overrideInfo ? req.target : null;
11061107
Storage.Objects.Rewrite rewrite =
11071108
storage
11081109
.objects()
@@ -1111,7 +1112,7 @@ private RewriteResponse rewrite(RewriteRequest req, String token) {
11111112
req.source.getName(),
11121113
req.target.getBucket(),
11131114
req.target.getName(),
1114-
req.overrideInfo ? req.target : null)
1115+
content)
11151116
.setSourceGeneration(req.source.getGeneration())
11161117
.setRewriteToken(token)
11171118
.setMaxBytesRewrittenPerCall(maxBytesRewrittenPerCall)
@@ -1132,6 +1133,7 @@ private RewriteResponse rewrite(RewriteRequest req, String token) {
11321133
.setDestinationPredefinedAcl(Option.PREDEFINED_ACL.getString(req.targetOptions))
11331134
.setUserProject(userProject)
11341135
.setDestinationKmsKeyName(Option.KMS_KEY_NAME.getString(req.targetOptions));
1136+
rewrite.setDisableGZipContent(content == null);
11351137
HttpHeaders requestHeaders = rewrite.getRequestHeaders();
11361138
setEncryptionHeaders(requestHeaders, SOURCE_ENCRYPTION_KEY_PREFIX, req.sourceOptions);
11371139
setEncryptionHeaders(requestHeaders, ENCRYPTION_KEY_PREFIX, req.targetOptions);
@@ -1460,6 +1462,7 @@ public HmacKey createHmacKey(String serviceAccountEmail, Map<Option, ?> options)
14601462
.hmacKeys()
14611463
.create(projectId, serviceAccountEmail)
14621464
.setUserProject(Option.USER_PROJECT.getString(options))
1465+
.setDisableGZipContent(true)
14631466
.execute();
14641467
} catch (IOException ex) {
14651468
span.setStatus(Status.UNKNOWN.withDescription(ex.getMessage()));
@@ -1714,6 +1717,7 @@ public Bucket lockRetentionPolicy(Bucket bucket, Map<Option, ?> options) {
17141717
.buckets()
17151718
.lockRetentionPolicy(bucket.getName(), Option.IF_METAGENERATION_MATCH.getLong(options))
17161719
.setUserProject(Option.USER_PROJECT.getString(options))
1720+
.setDisableGZipContent(true)
17171721
.execute();
17181722
} catch (IOException ex) {
17191723
span.setStatus(Status.UNKNOWN.withDescription(ex.getMessage()));

google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITGrpcTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
@RunWith(StorageITRunner.class)
5959
@CrossRun(
6060
backends = {Backend.TEST_BENCH},
61-
transports = {Transport.HTTP, Transport.GRPC})
61+
transports = {Transport.GRPC})
6262
public final class ITGrpcTest {
6363

6464
@Inject public Storage storage;
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
FROM gcr.io/cloud-devrel-public-resources/storage-testbench:v0.35.0
1+
FROM gcr.io/cloud-devrel-public-resources/storage-testbench:v0.36.0

0 commit comments

Comments
 (0)