Skip to content

Commit 207abd1

Browse files
authored
fix: plumb list blobs match glob option for grpc transport (#2759)
1 parent 88b3f62 commit 207abd1

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

google-cloud-storage/src/main/java/com/google/cloud/storage/UnifiedOpts.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -1228,8 +1228,7 @@ private MatchGlob(String val) {
12281228

12291229
@Override
12301230
public Mapper<ListObjectsRequest.Builder> listObjects() {
1231-
return CrossTransportUtils.throwHttpJsonOnly(
1232-
com.google.cloud.storage.Storage.BlobListOption.class, "matchGlob(String)");
1231+
return b -> b.setMatchGlobBytes(ByteString.copyFromUtf8(val));
12331232
}
12341233
}
12351234

google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITObjectTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -563,7 +563,6 @@ public void testListBlobsCurrentDirectoryIncludesBothObjectsAndSyntheticDirector
563563

564564
@Test
565565
// When gRPC support is added for matchGlob, enable this test for gRPC.
566-
@Exclude(transports = Transport.GRPC)
567566
public void testListBlobsWithMatchGlob() throws Exception {
568567
BucketInfo bucketInfo = BucketInfo.newBuilder(generator.randomBucketName()).build();
569568
try (TemporaryBucket tempBucket =

0 commit comments

Comments
 (0)