Skip to content

Revert "build(deps): update dependency com.coveo:fmt-maven-plugin to v2.12" #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BenWhitehead
Copy link
Contributor

Reverts #300

Version v2.12 merged in #300 is not compatible with google-java-format v1.7 due to a missing API. google-java-format v1.7 is necessary for java 8 compatibility.

com.google.googlejavaformat.java.ImportOrderer.reorderImports(Ljava/lang/String;Lcom/google/googlejavaformat/java/JavaFormatterOptions$Style;)Ljava/lang/String;

@BenWhitehead BenWhitehead requested a review from a team as a code owner August 25, 2021 20:08
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2021
@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2021
@BenWhitehead BenWhitehead merged commit 965508d into master Aug 25, 2021
@BenWhitehead BenWhitehead deleted the revert-300-renovate/com.coveo-fmt-maven-plugin-2.x branch August 25, 2021 20:20
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants