Skip to content

samples(test): add retry rule in tests #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2021
Merged

Conversation

anguillanneuf
Copy link
Contributor

Fixes #633

@anguillanneuf anguillanneuf requested a review from a team May 5, 2021 21:06
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels May 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2021
@anguillanneuf anguillanneuf changed the title samples(test): add retry in tests samples(test): add retry rule in tests May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #645 (997e851) into master (d2e5ab6) will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #645      +/-   ##
============================================
+ Coverage     78.30%   78.83%   +0.52%     
  Complexity      379      379              
============================================
  Files            27       27              
  Lines          3416     3420       +4     
  Branches        148      171      +23     
============================================
+ Hits           2675     2696      +21     
- Misses          649      651       +2     
+ Partials         92       73      -19     
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java 67.30% <0.00%> (-0.46%) 15.00% <0.00%> (ø%)
...a/com/google/cloud/pubsub/v1/TopicAdminClient.java 58.95% <0.00%> (+2.31%) 34.00% <0.00%> (ø%)
...om/google/cloud/pubsub/v1/SchemaServiceClient.java 60.91% <0.00%> (+3.44%) 20.00% <0.00%> (ø%)
...oogle/cloud/pubsub/v1/SubscriptionAdminClient.java 63.06% <0.00%> (+5.40%) 52.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e5ab6...997e851. Read the comment docs.

@shubha-rajan shubha-rajan merged commit 21028b3 into master May 5, 2021
@shubha-rajan shubha-rajan deleted the sample-tests branch May 5, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub.DeadLetterQueueIT: testQuickstart failed
3 participants