auto schema generation #2853
Merged
auto schema generation #2853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
commented
Oct 8, 2021
| @@ -244,11 +244,13 @@ <h2>Setting up <code><model-viewer></code> for good Lighthouse scores</h2> | |||
| <model-viewer | |||
| id="first" | |||
| src="../assets/ShopifyModels/Chair.glb" | |||
| poster="../assets/ShopifyModels/ChairPoster.png" | |||
There was a problem hiding this comment.
I had omitted the poster since we're using a custom slotted poster for extreme lazy loading, but we need to specify it here too because that's where the scheme gets the thumbnail info.
There was a problem hiding this comment.
I'll test this once it's merged and deployed by checking this example here: https://search.google.com/test/rich-results
elalish
commented
Oct 8, 2021
| @@ -114,7 +116,7 @@ export class ModelScene extends Scene { | |||
|
|
|||
| this.name = 'ModelScene'; | |||
|
|
|||
| this.element = element; | |||
| this.element = element as ModelViewerElement; | |||
There was a problem hiding this comment.
I probably should have done this ages ago; I bet there a bunch of casts (especially in tests) that probably aren't necessary anymore.
tpsiaki
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
generate-schemaattribute which automatically generates the 3DModel schema and attaches it to the page's header.