Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTest must use proper paths to executables #901

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

gjasny
Copy link
Contributor

@gjasny gjasny commented Nov 5, 2019

With the following syntax:

  add_test(NAME <name> COMMAND <command> [<arg>...])

if <command> specifies an executable target it will automatically
be replaced by the location of the executable created at build time.

This is important if a <Configuration>_POSTFIX like _d is used.

With the following syntax:

```
  add_test(NAME <name> COMMAND <command> [<arg>...])
```

if `<command>` specifies an executable target it will automatically
be replaced by the location of the executable created at build time.

This is important if a `<Configuration>_POSTFIX` like `_d` is used.
@LebedevRI
Copy link
Collaborator

Hm, indeed.

@coveralls
Copy link

coveralls commented Nov 5, 2019

Coverage Status

Coverage remained the same at 91.99% when pulling 6e54c8b on gjasny:cmake-test-name-command into cf446a1 on google:master.

@LebedevRI
Copy link
Collaborator

appveyor failure seems related

Instead of `-c` the uppercase `-C` must be used to select a config.
But better use the longopt.
@LebedevRI
Copy link
Collaborator

LG, thank you for the fix.

@LebedevRI LebedevRI merged commit c50ac68 into google:master Nov 5, 2019
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this pull request Sep 11, 2020
* CTest must use proper paths to executables

With the following syntax:

```
  add_test(NAME <name> COMMAND <command> [<arg>...])
```

if `<command>` specifies an executable target it will automatically
be replaced by the location of the executable created at build time.

This is important if a `<Configuration>_POSTFIX` like `_d` is used.

* Fix typo in ctest invocation

Instead of `-c` the uppercase `-C` must be used to select a config.
But better use the longopt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants