-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change DM grammar source #6605
Change DM grammar source #6605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't accept this change.
Whilst the grammar files are licensed under MIT, the over-all repo is licensed by GPL-3 which means we'll be shipping code that is covered by this license which we can't do.
I'm also not sure GPL3 allows sub-licensing, but that's not relevant as we don't include just the grammar files.
ad591f3
to
e53b968
Compare
Is this fine? The samples for the new extensions are about as complicated as they can get, so they aren't from a real-world project |
No. We want real world examples as documented. This is used to train the classifier. The |
e53b968
to
c7448cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
thanks for taking on the grammar maintenance by the way vvvv. |
c7448cb
to
b61f465
Compare
Moved the repo elsewhere |
type: git_submodule | ||
homepage: https://github.com/PJB3005/atomic-dreams | ||
homepage: https://github.com/vvvv-vvvv/dm-syntax.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't match the URLs used elsewhere. If you used the script/add-grammar --replace
command, it should have resulted in the same URL used elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did, and it didn't replace this
b61f465
to
9c6036c
Compare
thanks lildude |
Description
Changed the DM grammar to a better maintained source that has new keywords
Checklist: