Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: git-ecosystem/git-credential-manager
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 749e287571c78a2b61f926ccce6a707050871ab8
Choose a base ref
...
head repository: git-ecosystem/git-credential-manager
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 99e2f7f60e7364fe807e7925f361a81f3c47bd1b
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Oct 30, 2024

  1. streams: only consider LF and CRLF as newlines 

    Git only considers LF (`\n`) and CRLF (`\r\n`) as valid line endings for
the Git credential protocol. Lone carriage-returns should be treated as
part of the value, and not a delimiter in the credential protocol.

Override the behaviour of the standard `StreamReader`'s `ReadLineAsync`
method to only break on LF or CRLF, in alignment with Git. Note that
we also override the non-async `ReadLine` method too as this is also
implemented separatley in the base class from the async version.
We must also make allowances for .NET Framework where the override
of `ReadLineAsync` that takes a `CancellationToken` does not exist.
    @mjcheetham
    mjcheetham committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    61e4fa4 View commit details
    Browse the repository at this point in the history

  2. release.yml: use gatewatcher mac app certificate 

    Use Gatewatcher to provision the Application certificate and password
secrets in our release workflow.
    @mjcheetham
    mjcheetham committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    99e2f7f View commit details
    Browse the repository at this point in the history
Loading