This repository was archived by the owner on May 6, 2024. It is now read-only.
Support configurable sampling rate for datadog #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @JTCunning. This adds two parameters to the config file |
tkaemming
approved these changes
May 23, 2019
cdc/utils/stats.py
Outdated
| "properties": { | ||
| "host": {"type": "string"}, | ||
| "port": {"type": "integer"}, | ||
| "msg_sampling_rate": {"type": "number"}, |
There was a problem hiding this comment.
I'd probably change these to "message" since we've used that rather than "msg" pretty consistently, including in other configurations like the commit_positions_after_flushed_messages Source backend configuration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration paramters for sampling rate.
Since "message written" is orders of magnitude bigger than task execution I added two separate sampling rates so we can still get good signal from task executions.
This required some refactoring of the stats api we use since producer.py does not have access to the configuration. This new structure also allows us to provide a dummy Stats object to the producer for those that do not have datadog up and running.