Skip to content

Publish docker images on dockerhub #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 26, 2019
Merged

Publish docker images on dockerhub #187

merged 7 commits into from
Mar 26, 2019

Conversation

godu
Copy link
Contributor

@godu godu commented Aug 1, 2018

On each tag push, Travis will build and publish 2 images

  • ifsharp/ifsharp:latest
  • ifsharp/ifsharp:<tag>

Demo

If create new tag on my fork https://github.com/godu/IfSharp/releases/tag/v3.0.1
Travis build : https://travis-ci.com/godu/IfSharp/builds/80667557
DockerHub tags : https://hub.docker.com/r/godu/ifsharp/tags/

Next

  • Create docker account fsprojects
  • Adds DOCKER_USERNAME DOCKER_PASSWORD on travis
  • Publish a new tag, wait and see

@cgravill
Copy link
Member

cgravill commented Aug 2, 2018

Looks like a nice improvement to have an automated deployment.

In terms of the username and password, any suggestions how this would be managed? Do you know if other docker images are automatically published and how they handle accounts like this?

@godu
Copy link
Contributor Author

godu commented Aug 3, 2018

@cgravill In my company, we build images for every commit and publish it to docker registry.
Cf https://hub.docker.com/u/coorpacademy/
I have some knowledge about DockerHub, and this is my following advice :

Docker doesn't provide access token system like github. I think travis are right, we have to use username/password as credentials.

You should :

@cgravill
Copy link
Member

OK, this seems better done at the fsprojects level as we don't want single points of failure. Can we join with whatever is happening here: https://hub.docker.com/_/fsharp/ ?

@dsyme
Copy link
Contributor

dsyme commented Mar 26, 2019

Hi all,

@gbaydin and I are diving into iFSharp and we've realised that we will need dockerhub images for iFSharp.

I've created a community organization on docker cloud https://cloud.docker.com/u/fsprojects/ which we can use for all "fsprojects" projects.

@baronfel - If you'd like to be co-admin on that please send me your dockerhub ID.

@cgravill - Could you confirm your dockerhub ID is "cgravill"?

thanks
don

@cgravill
Copy link
Member

Hi @dsyme yes that's me and I've had a notification from docker hub.

@dsyme
Copy link
Contributor

dsyme commented Mar 26, 2019

@godu @cgravill We'll look at updating this PR and getting this in, if that's ok

@cgravill
Copy link
Member

Sure, would you like me to resolve the conflicts? I know what's going on with them - enabling the experimental .NET Core builds, and reordering the readme.

@baronfel
Copy link

Excellent news, and of course I'll help. My docker hub ID is [email protected].

@dsyme
Copy link
Contributor

dsyme commented Mar 26, 2019

Sure, would you like me to resolve the conflicts? I know what's going on with them - enabling the experimental .NET Core builds, and reordering the readme.

Yes please! thanks!

@cgravill
Copy link
Member

Done! I haven't checked the local Docker instructions still work. Note to other that this Docker build is targeting the stable Mono version of this.

Getting to .NET Core on Docker in the future would be great.

@dsyme
Copy link
Contributor

dsyme commented Mar 26, 2019

Getting to .NET Core on Docker in the future would be great.

I'll look at this too

@dsyme
Copy link
Contributor

dsyme commented Mar 26, 2019

OK, so we've

  • updated this with what we think is necessary to push docker images automatically (on all tags)
  • added encrypted the username and password to push to fsprojects/ifsharp docker hub
  • pushed experimental tag v3.0.0-beta3docker

This is now building at https://travis-ci.org/fsprojects/IfSharp/builds/511585157 and all going well the results will appear at https://cloud.docker.com/u/fsprojects/repository/registry-1.docker.io/fsprojects/ifsharp

@cgravill
Copy link
Member

That's great and it looks like the .NET Core SDK is now working correctly on Travis too!

@dsyme dsyme merged commit 44dea69 into fsprojects:master Mar 26, 2019
@dsyme
Copy link
Contributor

dsyme commented Mar 26, 2019

All working, images here https://cloud.docker.com/u/fsprojects/repository/registry-1.docker.io/fsprojects/ifsharp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants