-
Notifications
You must be signed in to change notification settings - Fork 0
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: freckle/yesod-page-cursor
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.0.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: freckle/yesod-page-cursor
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.0.5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 6 files changed
- 1 contributor
Commits on Feb 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7bb1987 - Browse repository at this point
Copy the full SHA 7bb1987View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a37a3f - Browse repository at this point
Copy the full SHA 7a37a3fView commit details
Commits on Mar 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0bd42cf - Browse repository at this point
Copy the full SHA 0bd42cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb8dfdc - Browse repository at this point
Copy the full SHA cb8dfdcView commit details -
This update replaced `Link` with `IsURI uri => Link uri`, allowing different URI-like types to be used. This means we cannot use both 1.1 (in current LTS) and 1.2 (just landed in nightly). This PR creates a small module that exposes a URI-specific interface used by the library. CPP can break tooling (brittany), so to make it more tolerable, I try to isolate it to a small Compat module like this, vs peppering it around in the "actual code". As an alternative, we could have raise the lower bound on http-link-header to >= 1.2. That version isn't in LTS yet, so we would ourselves need to release as a major version bump or we would be pulled out as incompatible. So we would then have to either use nightly as our default resolver here, or bring newer http-link-header in as an extra-dep. Folks using us (including ourselves) would either have to remain behind for now, use nightly themselves, or bring in http-link-header and us in as extra-deps. Remaining behind is probably fine for our users (that's sort of the point of choosing LTS), but for us as maintainers having to port a potential bugfix back to the 1.1x branch is not the kind of thing we normally set ourselves up to need to do. And all of the resolver/extra-dep shuffling would ideally be rewound once all the things moved back into LTS again. Because these activities spider out into our users, it seems worth avoiding. CPP is a slippery-slope of maintenance burden that I normally do not like to take on, but the trade-offs in the alternative are too much for me in this case.
Configuration menu - View commit details
-
Copy full SHA for 5209bf1 - Browse repository at this point
Copy the full SHA 5209bf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 117bf51 - Browse repository at this point
Copy the full SHA 117bf51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1970904 - Browse repository at this point
Copy the full SHA 1970904View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.0.0.4...v2.0.0.5