Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: freckle/yesod-page-cursor
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.0.10
Choose a base ref
...
head repository: freckle/yesod-page-cursor
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.1.0
Choose a head ref
  • 3 commits
  • 8 files changed
  • 1 contributor

Commits on May 16, 2022

  1. Add absolute version of withPage{,Link} 

    Returning absolute pagination links is almost always what you want.
Clients shouldn't need to maintain their own state to supply the domain
when making follow-up calls to later pages based on the responses they
have. Including absolute links makes this trivial.

However, we want to handle the transition carefully since any clients in
use today will probably break if they're expecting relative links and
suddenly start getting absolute ones. Therefore, we're making it opt-in
on the part of our library users so they can manage their own clients'
expectations. Therefore, we're adding "Absolute"-suffixed versions of
our two main functions.

As for implementation, I chose to completely duplicate the code-path top
to bottom. This was the only way I could find to avoid adding the new
Yesod class-constraint to the existing functions (and thus triggering a
major version bump). Eventually, the non-Absolute versions will go away,
resolving the duplication naturally.
    @pbrisbin
    pbrisbin committed May 16, 2022
    Configuration menu
    Copy the full SHA
    35fa0a5 View commit details
    Browse the repository at this point in the history

  2. Update README

    @pbrisbin
    pbrisbin committed May 16, 2022
    Configuration menu
    Copy the full SHA
    6cf3e8e View commit details
    Browse the repository at this point in the history

  3. Version bump

    @pbrisbin
    pbrisbin committed May 16, 2022
    Configuration menu
    Copy the full SHA
    e83f386 View commit details
    Browse the repository at this point in the history
Loading