Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: freckle/hspec-junit-formatter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.2.1
Choose a base ref
...
head repository: freckle/hspec-junit-formatter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.2.2
Choose a head ref
  • 3 commits
  • 8 files changed
  • 1 contributor

Commits on Nov 29, 2021

  1. Configuration menu
    Copy the full SHA
    1da5f33 View commit details
    Browse the repository at this point in the history
  2. Add file and line attributes

    Location information isn't an official part of the JUnit XML spec, so
    various conventions have emerged for reporting locations such as within
    the name attribute, inferring from the classname using project structure
    assumptions, or including it in the content of the testcase node (as we
    do).
    
    At least one tool* that reads JUnit reports will look for file and
    line attributes if present on the testcase node. To better support this
    and any similarly-behaving tools, let's add them.
    
    *mikepenz/action-junit-report
    
    A note about Item locations:
    
    itemLocation is almost always present, but in the case of a positioned
    result it differs from that in meaningful way:
    
        it "does a thing" $ do      // <-- itemLocation
          x <- this
          y <- that
          x `shouldBe` y            // <-- itemResultLocation
    
    Therefore, we should prefer itemResultLocation but can fallback to
    itemLocation if it's missing. This gets a best-effort location of the
    "it" for cases without positioned results (e.g. Success), as visible in
    the golden.xml diff.
    pbrisbin authored Nov 29, 2021
    Configuration menu
    Copy the full SHA
    5a89e07 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Version bump

    pbrisbin committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    d9f1d1f View commit details
    Browse the repository at this point in the history
Loading