fix(vimwiki): VimwikiHeader highlights and URL metadata
#575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VimwikiHeader highlights and URL metadataVimwikiHeader highlights and URL metadata
VimwikiHeader highlights and URL metadataVimwikiHeader highlights and URL metadata
|
ty! |
folke
pushed a commit
that referenced
this pull request
Jul 6, 2024
🤖 I have created a release *beep* *boop* --- ## [4.3.1](v4.3.0...v4.3.1) (2024-07-06) ### Bug Fixes * **leap:** use `LeapLabel` ([#582](#582)) ([9460bc9](9460bc9)) * **vimwiki:** `VimwikiHeader` highlights and URL metadata ([#575](#575)) ([d8e570f](d8e570f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
georgeharker
pushed a commit
to georgeharker/tokyonight.nvim
that referenced
this pull request
Jul 9, 2024
## What is this PR for? Vimwiki support was added in [8850021](folke@8850021) but there was a typo in the generation of the `VimwikiHeader` highlights and instead they were generated under `VimwikiHeaer`. It also seems the the URL was set to headlines.nvim by mistake, presumably because this file was based off of the headlines.nvim group file. Disclaimer: I don't actually use vimwiki but I was looking through the commits and saw this easy to fix bug so I did it myself.
georgeharker
pushed a commit
to georgeharker/tokyonight.nvim
that referenced
this pull request
Jul 9, 2024
🤖 I have created a release *beep* *boop* --- ## [4.3.1](folke/tokyonight.nvim@v4.3.0...v4.3.1) (2024-07-06) ### Bug Fixes * **leap:** use `LeapLabel` ([folke#582](folke#582)) ([9460bc9](folke@9460bc9)) * **vimwiki:** `VimwikiHeader` highlights and URL metadata ([folke#575](folke#575)) ([d8e570f](folke@d8e570f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Vimwiki support was added in 8850021bed1d8595581a5903fd03acacf0d12af5 but there was a typo in the generation of the
VimwikiHeaderhighlights and instead they were generated underVimwikiHeaer. It also seems the the URL was set to headlines.nvim by mistake, presumably because this file was based off of the headlines.nvim group file.Disclaimer: I don't actually use vimwiki but I was looking through the commits and saw this easy to fix bug so I did it myself.