fix(diff): fix incorrect argument in diff calculation

azlam-abdulsalam · azlam-abdulsalam · commit 63ad7e4e3759 · 2024-01-09T21:22:16.000+11:00
diff --git a/packages/sfp-cli/src/core/package/diff/PackageDiffImpl.ts b/packages/sfp-cli/src/core/package/diff/PackageDiffImpl.ts
@@ -112,7 +112,7 @@ export default class PackageDiffImpl {
             if(this.diffOptions?.useBranchCompare)
             {
                 const mergeBase = await git.raw(['merge-base', this.diffOptions.branch, this.diffOptions.baseBranch]);
-                let modified_files = await git.diff(['--name-only', this.diffOptions.branch,, mergeBase.trim()]);
+                let modified_files = await git.diff(['--name-only', this.diffOptions.branch, mergeBase.trim()]);
 
                  // Check whether the package has been modified
                 for (let filename of modified_files) {

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ export default class PackageDiffImpl {`
`112`	`112`	`if(this.diffOptions?.useBranchCompare)`
`113`	`113`	`{`
`114`	`114`	`const mergeBase = await git.raw(['merge-base', this.diffOptions.branch, this.diffOptions.baseBranch]);`
`115`		`- let modified_files = await git.diff(['--name-only', this.diffOptions.branch,, mergeBase.trim()]);`
	`115`	`+ let modified_files = await git.diff(['--name-only', this.diffOptions.branch, mergeBase.trim()]);`
`116`	`116`
`117`	`117`	`// Check whether the package has been modified`
`118`	`118`	`for (let filename of modified_files) {`