-
Notifications
You must be signed in to change notification settings - Fork 345
Show Dart file locations in the stacktraces for errors #8385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
flutter-candidate.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the latest candidate in g3. It contains flutter/flutter#155846 which is required so that we can pull in the latest version of package:stack_trace
packages/devtools_app/lib/src/framework/app_error_handling.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/framework/app_error_handling.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/framework/app_error_handling.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thank you for working on this! Would be a bonus at some point if some of this logic could get upstreamed into a dart package so all Flutter web apps could have an easy way to handle source mapping.
Fixes #7392
This PR:
dart2js mapped stacktrace:

dart2wasm mapped stacktrace:
