Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin_helper/server: Add receive_buffer_size parameter in transport section #4649

Merged
merged 2 commits into from
Nov 26, 2024
Merged

plugin_helper/server: Add receive_buffer_size parameter in transport section #4649

merged 2 commits into from
Nov 26, 2024

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Sep 27, 2024 •
edited by daipom
Loading

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:
This patch will allow to adjust receive buffer size of UDP socket like in_udp plugin.
Related to #1789

Docs Changes:
fluent/fluentd-docs-gitbook#518

Release Note:
The same as the title

@Watson1978 Watson1978 mentioned this pull request Sep 27, 2024
Merged
@Watson1978 Watson1978 marked this pull request as ready for review September 27, 2024 04:51
@daipom
Copy link
Contributor

daipom commented Sep 27, 2024

Thanks! Is this only for UDP? Is there any reason?

@Watson1978
Copy link
Contributor Author

Make sense.
I just referred to the in_udp plugin...
I might need to add receive_buffer_size parameter in in_tcp plugin too.

@Watson1978 Watson1978 marked this pull request as draft September 27, 2024 05:28
@daipom
Copy link
Contributor

daipom commented Sep 27, 2024

I see!
Should this be server helper's option so that all plugins using the helper can use this option?

SO_LINGER Example:

@Watson1978 Watson1978 force-pushed the syslog/receive_buffer_size branch 2 times, most recently from e0927eb to 9206253 Compare October 3, 2024 08:39
@Watson1978 Watson1978 changed the title in_syslog: add receive_buffer_size parameter in transport plugin_helper/server: Add receive_buffer_size parameter in transport section Oct 3, 2024
@Watson1978 Watson1978 marked this pull request as ready for review October 8, 2024 06:08
@daipom daipom added this to the v1.18.0 milestone Nov 1, 2024
@daipom daipom self-requested a review November 26, 2024 05:42
daipom
daipom approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit ebc55b0 into fluent:master Nov 26, 2024
15 of 16 checks passed
@Watson1978 Watson1978 deleted the syslog/receive_buffer_size branch November 27, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daipom daipom daipom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Watson1978 @daipom