fluentd command: fix '--plugin'('-p') option not to overwrite default value #4605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is explained as "add plugin directory". However, since v1.16.0, the behavior has changed to overwrite the default value unintentionally. (PR: fluent#4064, commit: 41678bf). We should revert it to the original behavior. Signed-off-by: Daijiro Fukuda <[email protected]>
8704083
to
fe5843f
Compare
daipom
added a commit
that referenced
this pull request
Aug 20, 2024
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
added a commit
that referenced
this pull request
Aug 20, 2024
Signed-off-by: Daijiro Fukuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
This option is explained as "add plugin directory".
However, since v1.16.0, the behavior has changed to overwrite the default value unintentionally.
(PR: #4064, commit: 41678bf).
We should revert it to the original behavior.
Docs Changes:
Not needed.
Release Note:
The same as the title.