Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FrozenError in http_server plugin helper #4598

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Watson1978
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #4597

What this PR does / why we need it:
This patch will be able to handle frozen strings as paths to mount in http server.

Docs Changes:

Release Note:

This patch will be able to handle frozen strings as paths to mount in http server.

Signed-off-by: Watson <[email protected]>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom
Copy link
Contributor

daipom commented Aug 16, 2024

v1.17.1?

@ashie ashie added this to the v1.17.1 milestone Aug 16, 2024
@ashie ashie merged commit c8c6040 into fluent:master Aug 16, 2024
16 checks passed
@Watson1978 Watson1978 deleted the fix-http_server branch August 16, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FrozenError: can't modify frozen String in http_server plugin helper
3 participants