Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: unify YAML file extension to .yml #4429

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Mar 11, 2024

Which issue(s) this PR fixes:

Fixes N/A

What this PR does / why we need it:

It is not harmful because GitHub allows both of file extensions (.yaml and .yml), but it may be better to unify it for consistency.

.yml is used in https://docs.github.com/en/actions/learn-github-actions/understanding-github-actions

Docs Changes:

N/A

Release Note:

N/A

It is not harmful because GitHub allows both of file extensions (.yaml
and .yml), but it may be better to unify it for consistency.

.yml is used in https://docs.github.com/en/actions/learn-github-actions/understanding-github-actions

Signed-off-by: Kentaro Hayashi <[email protected]>
@daipom
Copy link
Contributor

daipom commented Mar 11, 2024

Thanks!

.yml is used in https://docs.github.com/en/actions/learn-github-actions/understanding-github-actions

I agree with unifying .yml based on this reason.

Should we wait a bit to see if there are any other opinions?

@ashie ashie merged commit d55f444 into fluent:master Mar 11, 2024
11 of 16 checks passed
@kenhys kenhys deleted the unify2yml branch March 11, 2024 04:10
@ashie ashie added this to the v1.17.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants