Fix for rotate_age where Fluentd passes as Symbol #4311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
4ec5b7b
to
5649803
Compare
|
@daipom , have added the DCO to the commits. The second commit do not have any changes actually, since i had missed to add DCO on the first commit, tried to add in the next assuming it would take for other also. Thanks, |
|
@daipom, have pushed code changes for the tests which were failing and on my local windows env, these loglevel tests have passed. Please do the needful. |
|
@mrudrego Thanks for fixing the tests, but the new commit does not have DCO. |
…xpects String Signed-off-by: mrudrego <[email protected]>
Signed-off-by: mrudrego <[email protected]> Signed-off-by: mrudrego <[email protected]>
Signed-off-by: mrudrego <[email protected]>
1a7e8ed
to
70cf9bb
Compare
|
@daipom can you please provide approval for the further checks. Thanks, |
|
Hi @daipom, can you please do the needful. Thanks, |
ashie
reviewed
Oct 17, 2023
daipom
requested changes
Oct 17, 2023
Signed-off-by: mrudrego <[email protected]>
Signed-off-by: mrudrego <[email protected]>
daipom
approved these changes
Oct 18, 2023
daipom
pushed a commit
to daipom/fluentd
that referenced
this pull request
Oct 31, 2023
Fix for rotate_age where Fluentd passes as Symbol while Ruby Logger expects String --------- Signed-off-by: mrudrego <[email protected]> Signed-off-by: mrudrego <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for rotate_age where Fluentd passes as Symbol while Ruby Logger expects String
Which issue(s) this PR fixes:
Fixes #4227
What this PR does / why we need it:
Docs Changes:
Release Note: