Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Combine chained method calls #4201

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

Garfield96
Copy link
Contributor

Which issue(s) this PR fixes:
Partially resolves: #4099

What this PR does / why we need it:
This PR combines some chained method calls into one specialized call. This improves readability and performance since unnecessary intermediate steps are removed.

Docs Changes:
None

Release Note:

@daipom daipom self-requested a review June 15, 2023 10:41
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
This looks good to me!

I want to wait for other maintainers' opinions on the timing of the merge.

@daipom daipom added this to the v1.17.0 milestone Jun 16, 2023
@daipom
Copy link
Contributor

daipom commented Jun 16, 2023

We will merge this at the timing of v1.17.0.
Please wait for a while.

@Garfield96
Copy link
Contributor Author

Hi @daipom,
Thanks for reviewing. It's fine for me to merge it into v1.17.0, but I like to do some additional refactorings, which would result in merge conflicts. I didn't include them in this PR to keep it small and to facilitate the review, and I planned to create a follow-up PR after this PR was merged. However, I fear that by doing this the additional changes won't make it into v1.17.0. Shall I add the changes to this PR instead?

@daipom daipom merged commit 02ae0ae into fluent:master Jun 20, 2023
@daipom
Copy link
Contributor

daipom commented Jun 20, 2023

We will merge this at the timing of v1.17.0.
Please wait for a while.

We prepare v1.16 branch for v1.16 release.
Now, we can merge this to the master branch!
Thanks, @Garfield96!

@daipom daipom modified the milestones: v1.17.0, v1.16.2 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate RuboCop Performance
2 participants