Fix broken argument unpacker of ChunkMessagePackEventStreamer.each
#4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days |
ashie
reviewed
Jul 10, 2023
8e8f46b
to
9e19bdd
Compare
|
Rebased to the latest master. |
The argument `unpacker` of `ChunkMessagePackEventStreamer.each` seems to have been added in order to match the feature with `EventStream` at c6c6c03. However, that previous implementation at that point does not work as expected. It has never causes any issues just because the argument was not used at all. It could be implemented so that this argument is used, but given that it has not been used so far, there is little need for it. Signed-off-by: Daijiro Fukuda <[email protected]>
9e19bdd
to
5121054
Compare
|
I'm concerned about the many failures of CI. |
|
I think the failures have nothing to do with this PR. |
ashie
approved these changes
Jul 11, 2023
|
Thanks! |
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None.
What this PR does / why we need it:
The argument
unpackerof ChunkMessagePackEventStreamer.each seems to have been added in order to match the feature withEventStreamatHowever, that previous implementation at that point does not work as expected.
It has never caused any issues just because the argument was not used at all.
When
unpackeris passed, the following will be executed.This just iterates the internal buffer of the unpacker without reading
ioof the chunk.Thus it seems to me that this doesn't work as expected.
Note: It could be implemented so that this argument is used, but given that it has not been used so far, there is little need for it.
Docs Changes:
Not needed since it is an internal fix.
Release Note:
Same as the title.