-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_tcp
: Add message_length_limit
to drop large incoming data
#4137
Conversation
Behavior of
|
message_length_limit
to drop large incoming datain_tcp
: Add message_length_limit
to drop large incoming data
47463b6
to
283a3b3
Compare
Writing to a socket at high speed can cause multiple writes to be stored in the buffer before the server reads them. It is undesirable that high-speed writing causes the total buffer size to exceed the limit and drop the records even if each record size does not exceed the limit. So I fixed to check the size at 2 points: delimited one message size and total remaining buffer size. One concern is whether this fix will affect the performance improvement of the next fix. |
Add the same feature to `in_tcp` as `message_length_limit` in `in_udp`, to drop too large incoming data. Signed-off-by: Daijiro Fukuda <[email protected]> Co-authored-by: Takuro Ashie <[email protected]>
283a3b3
to
0d9c320
Compare
Thanks for your review! |
fluent/fluentd#4137 Signed-off-by: Daijiro Fukuda <[email protected]>
Which issue(s) this PR fixes:
None.
What this PR does / why we need it:
Add the same feature to
in_tcp
asmessage_length_limit
inin_udp
, to drop too large incoming data.Docs Changes:
fluent/fluentd-docs-gitbook#452
Release Note:
Same as the title.
TODO: