Server helper: Suppress error of UDPServer over max_bytes on Windows #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93dbdcd
to
8aed97a
Compare
ashie
reviewed
Apr 10, 2023
This fix just suppresses the error message and output a info level log.
On Windows, `UDPSocket::recv` and `UDPSocket::recvfrom` can
raise `Errno::EMSGSIZE` error when the receiving data size is
larger than the `maxlen`, the value specified as the method's
argument.
(On non-Windows, this error doesn't happen, and we can receive data
that is cut off to the specified size.)
We need to consider this case since this causes an unexpected
error message as follows.
unexpected error in processing UDP data
error_class=Errno::EMSGSIZE
error="A message sent on a datagram socket was larger than
the internal message buffer or some other network limit,
or the buffer used to receive a datagram into was smaller
than the datagram itself. - recvfrom(2)"
On Windows, we can't cut data off the same way as Non-Windows.
So, the data is simply ignored on Windows.
It is not a big problem since cutting data off usually causes a
failure of parsing and the data is eventually ignored.
We want information about what data is ignored, but it is
difficult to know it. That is an issue for the future.
Ref: `winsock` specification
* https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-recvfrom
* https://learn.microsoft.com/en-us/windows/win32/winsock/windows-sockets-error-codes-2
Ref: Ruby implementation
* https://github.com/ruby/ruby/blob/e51014f9c05aa65cbf203442d37fef7c12390015/win32/win32.c#L3540-L3589
* https://github.com/ruby/ruby/blob/e51014f9c05aa65cbf203442d37fef7c12390015/win32/win32.c#L3730-L3782
Signed-off-by: Daijiro Fukuda <[email protected]>
8aed97a
to
1bd8b00
Compare
|
Thanks! |
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None.
This fixes the problem revealed in the following PR.
What this PR does / why we need it:
This PR just suppresses error message of UDPServer over max_bytes on Windows.
Suppressed error message on Windows:
(Please see #4117 (comment) for details)
New info message on Windows:
On Windows,
UDPSocket::recvandUDPSocket::recvfromcan raiseErrno::EMSGSIZEerror when the receiving data size is larger than themaxlen, the value specified as the method's argument.(On non-Windows, this error doesn't happen, and we can receive data that is cut off to the specified size.)
On Windows, we can't cut data off the same way as Non-Windows.
So the data is simply ignored on Windows.
It is not a big problem since cutting data off usually causes a failure of parsing and the data is eventually ignored.
We want information about what data is ignored, but it is difficult to know it.
That is an issue for the future.
Ref
winsockspecificationDocs Changes:
TODO. We should add a document about this Windows specification.
Release Note:
Same as the title.