-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive issue auto closer #4116
Revive issue auto closer #4116
Conversation
This reverts commit d005002. Signed-off-by: Takuro Ashie <[email protected]>
For opening normal issues we use issue form for now instead of template so that users no longer able to neglect the issue template. For this purpose auto closer isn't needed anymore. In addition fluentd maintainers might open issues which doesn't follow the template via other systems such as GitHub Projects. Signed-off-by: Takuro Ashie <[email protected]>
Signed-off-by: Takuro Ashie <[email protected]>
As I described in 5846a07 I think roots/issue-closer-action isn't needed in any way. |
Untriaged issues should be closed automatically. |
I basically agree. I have a question about automatically staling or closing items that are not labeled at all, but I think it is a good idea to automatically stale and close items that are labeled with Even if we don't decide in detail now, we can tune these things later. |
I introduced |
In |
Oh, automatically adding |
In addition, shorten `days-before-stale` for triaged issues. Signed-off-by: Takuro Ashie <[email protected]>
I've added same settings for fluent-plugin-kafka, and shorten |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I agree.
Signed-off-by: Takuro Ashie <[email protected]>
223c043
to
93a5cb2
Compare
Which issue(s) this PR fixes:
N/A
What this PR does / why we need it:
Although issue auto closer is disabled at d005002 without discussion, I think we still need it at least for
waiting-for-users
andstable
labels.We need to revive it and tune which issues should be closed automatically.
Docs Changes:
None.
Release Note:
None.