SocketManager: Use new feature to select path automatically #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
treasure-data/serverengine#140 (comment)
We should fix this too, but it seems difficult to do it before the next release... |
e481703
to
2a3f39d
Compare
|
I've released ServerEngine v2.3.2. |
|
Thanks! I have updated the dependency. Checking tests... |
|
The currently failing tests are not related to this issue. |
Use ServerEngine's new feature: treasure-data/serverengine#143 On Windows, this prevents SocketManager from wrongly selecting an unavailable port, such as a port in excluded port range. Signed-off-by: Daijiro Fukuda <[email protected]>
Signed-off-by: Daijiro Fukuda <[email protected]>
893101f
to
34c3435
Compare
|
Rebased. |
Thanks! |
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ServerEngine's new feature:
treasure-data/serverengine#143
On Windows, this prevents SocketManager from wrongly selecting an unavailable port, such as a port in excluded port range.
Which issue(s) this PR fixes:
Fixes treasure-data/serverengine#140
(Sorry, I made the issue in ServerEngine, and not made it here.)
What this PR does / why we need it:
On Windows,
ServerEngine::SocketManager::generate_pathsometimes generates an unavailable port.This makes Fluentd fail to start.
To fix this, I made the fix for ServerEngine:
open(nil)to select path automatically treasure-data/serverengine#143This is a fix on Fluentd's side.
Docs Changes:
Not needed.
Release Note:
Fix bug that Fluentd sometimes tries to use an unavailable port and fails to start on Windows.